-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile click accessibility #11447
Mobile click accessibility #11447
Conversation
Sorry, forgot to mention that I have no custom panel to test, but the 2 lines of code are identical for each entrypoint. Also, I assume there is no need to add it to the |
Thanks for this PR! I'll dive into this tomorrow |
This should also close #11034 which seems like a duplicate issue. |
Any chance this can get in the upcoming Feb release? 🥺 |
I don't think that is wise, I would like it to go through a complete beta and some testing before shipping this into production. We are not sure if this will break anything... |
I understand the hesitation on a global setting, but...
If you still think extensive testing is necessary, here are the only 9 modules in the entire source tree that actually import the offending
|
I'm not worried about issues with current browsers but with the old browsers, like mentioned in that comment. I'm not sure what devices/browsers are affected. I guess we can put this in, as the beta generally doesn't find issues with old browsers anyway... |
|
In the meantime if needed, people could just stay on version 2022.2.0 until we have fixed this. |
Proposed change
Change the Polymer setting
cancelSyntheticClickEvents
to false globally in the UI. When left to true, it ends up breaking nearly all buttons in the UI for mobile screen readers.PS - I know the 2nd commit is only loosely related, but that comment would have saved me a bunch of time trying to figure out why putting the code there wasn't working
Type of change
Example configuration
N/A - Just flip VoiceOver or Talkback on with and without this change.
Additional information
Checklist